- Issue created by @Grimreaper
- First commit to issue fork.
- 🇬🇧United Kingdom jonathan1055
I have tested your project using the MR I have cerated on #3436819: Composer-lint fails if there are no php files in the project → . This is done using
# MR 168 Check for files before running parallel-lint - project: issue/gitlab_templates-3436819 ref: 3436819-no-files-for-parallel-lint
The composer-lint job now passes, and gives a message that 0 PHP files were found in the project.
- Issue was unassigned.
- Status changed to Postponed
over 1 year ago 6:12pm 31 March 2024 - 🇫🇷France Grimreaper France 🇫🇷
Thanks a lot @jonathan1055!
Waiting for the fix inside gitlab_templates directly.
- 🇬🇧United Kingdom jonathan1055
#3436819: Composer-lint fails if there are no php files in the project → has just been merged and you can see the commit listed in this link: compare/default-ref...main?from_project_id=96292. This shows all commits that are in 'main' but not yet reached 'default-ref'. If the commit is showing here then you need to wait.
You can also see all the commits and where the tags are. You can see at the moment there are two commits which are above the set of tags, meaning that these are only in 'main'
- 🇫🇷France Grimreaper France 🇫🇷
Hi @jonathan1055,
Thanks a lot to have pushed this forward!
No problem to keep the MR opened, if this may help. What about the issue? In which status should it remain?
Next issue I want to create is about PHPStan task triggered while there is currently no PHP files in this theme.
- Status changed to Active
over 1 year ago 9:05am 2 April 2024 - 🇬🇧United Kingdom jonathan1055
I have updated the issue summary and set the issue status to 'active'. I think that accuratelty reflects what is going on here.
Yes, open a new issue for PHPStan. I can work on it, and then will test it here. Thanks for your help.
- 🇫🇷France Grimreaper France 🇫🇷
Thanks!
PHPStan issue created #3437578: PHPStan job fails while there is no PHP files to scan → .
- 🇬🇧United Kingdom jonathan1055
I have just used this MR1 to test the fix on #3437578: PHPStan job fails while there is no PHP files to scan →
https://git.drupalcode.org/issue/sobki_theme_admin-3436970/-/pipelines/1...
In the above pipeline the phpstan job has not been added, which shows the fix works. - 🇫🇷France Grimreaper France 🇫🇷
As discussed with @jonathan1055, the issue and MR can be closed and re-open if needed.
Automatically closed - issue fixed for 2 weeks with no activity.