Contrib.social

Patch requirements

Open on Drupal.org →
Created on 28 March 2024, 3 months ago

Problem/Motivation

(If preferred, I can split this into two issues!)

Full details under "Proposed resolution"

Part 1

The patch info on the project page is outdated.

Part 2

Some of the patch info in composer.json is outdated or incomplete.

Steps to reproduce

N/A

Proposed resolution

Part 1

The project page says:

Currently, it's required to have the patch form #3173770: Allow field types extending entity_reference to use field widgets extending media_library → applied to your codebase.

But that issue has been fixed and included in core since (approximately) 9.4.x.

But there are other patches required by this module, per composer.json.

I recommend updating the project page as follows:

  1. Mention core #3263397-16 📌 Simplify form logic in media library Needs work , and also the IEF patch 🐛 Changes are lost when collapsing a paragraphs subform including an inline_entity_form Needs work .
  2. Theoretically with a caveat like "if your site uses IEF..."?
  3. Perhaps *start* by explaining that these patches will be applied automatically when you install media_library_media_modify via composer.

So, on the project page, under "Installation", something like...

Patches are required. They'll be applied automatically when you install Media Library Media Modify via composer.

(...it's not my favorite thing I've ever written, but the info is there lol -- edits welcome, obviously!)

Part 2

The patch info in composer.json could use an update (the readable info, not the actual patch links).

  1. Core: The comment reference is outdated -- probably simplest to just remove -10? -- i.e. make line 20 just say "Issue #3263397: Simplify...":
  2. IEF: It would be helpful to add the issue number -- in other words, make line 23 say: "Issue #3271293: Changes..."

Remaining tasks

Part 1: Maintainers update project page.
Part 2: Submit MR with updates to composer.json.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task
Status

Needs review

Version

1.0

Component

Documentation

Created by

🇺🇸United States alison

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024