- Issue created by @smurfxx
- ๐ฆ๐บAustralia nigelcunningham Geelong
Nigel Cunningham โ made their first commit to this issueโs fork.
- Status changed to Needs review
6 months ago 12:30pm 4 July 2024 - ๐ฆ๐บAustralia nigelcunningham Geelong
Here's an initial version, tested on a site I'm building with nodes and eck entities so far.
- ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
The attempt looks good to me. Did you experienced any drawbacks yet in the time of using? Did this project uses tests? If so we may need to add tests for this.
- ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
Also, we should try to add this to latest dev and possibly also to latest release which is 8.x 1.7.
- Status changed to Needs work
4 months ago 2:32pm 28 August 2024 - ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
Accordingly #5 this needs a re-roll...
- Status changed to RTBC
4 months ago 3:06pm 28 August 2024 - ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
Good news.
$ wget https://git.drupalcode.org/project/field_formatter_class/-/merge_requests/5.patch --2024-08-28 17:03:24-- https://git.drupalcode.org/project/field_formatter_class/-/merge_requests/5.patch Resolving git.drupalcode.org (git.drupalcode.org)... 146.75.122.217 Connecting to git.drupalcode.org (git.drupalcode.org)|146.75.122.217|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/plain] Saving to: '5.patch' 5.patch [ <=> ] 4.47K --.-KB/s in 0s 2024-08-28 17:03:24 (17.0 MB/s) - '5.patch' saved [4581] $ git apply -v 5.patch Checking patch field_formatter_class.module... Hunk #2 succeeded at 99 (offset 1 line). Applied patch field_formatter_class.module cleanly.
Ahead but still applies and works, so ... if one of the maintainers is quick enough, then ... ;-)
- ๐บ๐ธUnited States Chris Matthews
chris matthews โ made their first commit to this issueโs fork.
-
chris matthews โ
committed 81dfc3f0 on 8.x-1.x authored by
dqd โ
Issue #3436816 by nigel cunningham, dqd, smurfxx: Enable module on "...
-
chris matthews โ
committed 81dfc3f0 on 8.x-1.x authored by
dqd โ
- Status changed to Fixed
4 months ago 9:25pm 28 August 2024 - ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
Great reaction @ChrisMatthews, so it's merged to latest dev now. But let us keep issue titles and commit/merge comments in sync.
- ๐ซ๐ทFrance dqd London | N.Y.C | Paris | Hamburg | Berlin
Oops, sorry I didn't had your latest comment in my open tab from last night visible yet (only the commits) and I wanted to close the issue now. But you did already :) hah. And yeah, it's an FR indeed.
Automatically closed - issue fixed for 2 weeks with no activity.