Any set 'from' address is ignored when building the email body

Created on 28 March 2024, 9 months ago
Updated 4 April 2024, 9 months ago

If you set a 'from' address in the original message, this is not propagated to the message body in \Drupal\graph_mail\MailHelper::initMailBody so this setting is lost

Steps to reproduce:
* Use this module with Webform
* Configure a webform with an email handler and set the from address to something other than the site email address
* Submit the form to send the email
* 'from' address is not used

🐛 Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

🇳🇱Netherlands Lendude Amsterdam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Lendude
  • Merge request !22Use the supplied from address → (Open) created by Lendude
  • Status changed to Needs review 9 months ago
  • 🇳🇱Netherlands Lendude Amsterdam

    Added logic for handling a given 'from' address

    NB. this seemed to work previously, but looking at the old code, it was never supported, so I might be missing something

  • Pipeline finished with Success
    9 months ago
    Total: 139s
    #131451
  • Pipeline finished with Success
    9 months ago
    Total: 173s
    #131582
  • 🇳🇱Netherlands Lendude Amsterdam

    We were using 📌 Use 'From' email address for the sendmail POST user ID RTBC before, hence the working setup before updating, but that got reverted, so this is a new attempt at that but using the new helper method

    So redid that patch to use the new helper method. Also redid the current logic for the default from address since the ?? doesn't do what the code hopes it does since default_mail will get set to an empty string.

  • Pipeline finished with Success
    9 months ago
    Total: 139s
    #131595
  • Status changed to Needs work 9 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
Production build 0.71.5 2024