- Issue created by @pcambra
- ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- Status changed to Needs review
8 months ago 11:13am 22 April 2024 - Status changed to Needs work
8 months ago 4:30pm 22 April 2024 - ๐ช๐ธSpain rodrigoaguilera Barcelona
I'm not that familiar yet with the default Drupal template for gitlab-ci.
Can you upload a commit that allows phpcs to fail, fail the pipeline and then fix the phpcs error to make the phpcs pipeline green? - Status changed to Needs review
8 months ago 4:39am 23 April 2024 - ๐ฎ๐ณIndia mohd sahzad
Hello @rodrigoaguilera,
I have updated the gitlab-ci.yml file. Could you please review the latest commit?
Thank you!
- Status changed to Needs work
8 months ago 7:01am 23 April 2024 - ๐ช๐ธSpain rodrigoaguilera Barcelona
Please bear with me as I'm trying to understand.
I think allowing failures for phpcs should be as simple as overriding the job from the include
phpcs: allow_failure: false
This should give one phpcs error. Fail the pipeline, proving that phpcs errors are reported and we won't allow more in future MR.
Then fix the actual phpcs error (sorting uses alphabetically) commit the change and make the pipeline green again. - ๐ช๐ธSpain rodrigoaguilera Barcelona
Commited directly. Thanks for the contribution
- Status changed to Fixed
5 days ago 8:12pm 20 December 2024