GitlabCI integration

Created on 27 March 2024, 3 months ago
Updated 23 April 2024, 2 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

๐Ÿ‡ช๐Ÿ‡ธSpain pcambra Spain, ๐Ÿ‡ช๐Ÿ‡บ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @pcambra
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Mohd Sahzad

    Mohd Sahzad โ†’ made their first commit to this issueโ€™s fork.

  • Merge request !12added GitlabCI โ†’ (Open) created by Mohd Sahzad
  • Status changed to Needs review 2 months ago
  • Pipeline finished with Success
    2 months ago
    Total: 139s
    #153287
  • Status changed to Needs work 2 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain rodrigoaguilera Barcelona

    I'm not that familiar yet with the default Drupal template for gitlab-ci.
    Can you upload a commit that allows phpcs to fail, fail the pipeline and then fix the phpcs error to make the phpcs pipeline green?

  • Pipeline finished with Failed
    2 months ago
    #153931
  • Pipeline finished with Failed
    2 months ago
    #153932
  • Status changed to Needs review 2 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Mohd Sahzad

    Hello @rodrigoaguilera,

    I have updated the gitlab-ci.yml file. Could you please review the latest commit?

    Thank you!

  • Pipeline finished with Failed
    2 months ago
    #153937
  • Pipeline finished with Failed
    2 months ago
    #153938
  • Status changed to Needs work 2 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain rodrigoaguilera Barcelona

    Please bear with me as I'm trying to understand.

    I think allowing failures for phpcs should be as simple as overriding the job from the include

    phpcs:
        allow_failure: false

    This should give one phpcs error. Fail the pipeline, proving that phpcs errors are reported and we won't allow more in future MR.
    Then fix the actual phpcs error (sorting uses alphabetically) commit the change and make the pipeline green again.

Production build 0.69.0 2024