- Issue created by @fkildoo
- First commit to issue fork.
- Assigned to sourojeetpaul
- Merge request !663436528-Twitter/XIcon : Changes twitter logo to X. → (Merged) created by sourojeetpaul
- Issue was unassigned.
- Status changed to Needs review
8 months ago 7:17pm 27 March 2024 Hi, @fkildoo.
I've resolved the twitter logo related issue by updating it to the latest one and raised an MR.
Please have a look : https://git.drupalcode.org/project/uswds_base/-/merge_requests/66Had to update the referenced CDN to the latest version, which has the new X svg on it. Also checked that other logos are also appearing properly after the CDN update.
- 🇺🇸United States fkildoo Alexandria, VA
The update looks good except I wouldn't update the CDN version until the version of this theme matches. The X social media icon was introduced in USWDS 3.7.0. From the release notes:
Added the X social media icon. We added the X social media icon, but also preserved the legacy Twitter icon to allow teams to make the decision on when to update their social media information. (#5589)
- Status changed to Active
8 months ago 9:08pm 27 March 2024 - 🇺🇸United States mferanda
Looks like X was available with 3.7.0...
Change this to also bump up all the CDNs to 3.7.1. **Make sure you get the items in the starterkit folders. We can then just push this out as a 3.7.1 update instead of waiting on 3.8.0.
-
mferanda →
committed 420c6a30 on 3.7.x authored by
sourojeetpaul →
Issue #3436528 by sourojeetpaul, mferanda, fkildoo: Twitter/X Icon
-
mferanda →
committed 420c6a30 on 3.7.x authored by
sourojeetpaul →
- 🇺🇸United States mferanda
Modified this to only a change from twitter to x img.
- Status changed to Fixed
8 months ago 9:44pm 27 March 2024 - Status changed to Fixed
8 months ago 10:00pm 27 March 2024