- Issue created by @dewalt
- 🇧🇾Belarus dewalt
During a patch creation I found that the module use "base:" protocol to get URL, the error is caused by #3319509 patch. Anyway I think its a good improvement to use RedirectDestinationTrait, so I keep patch below. Also there is a chance that #3319509 would be fixed in this way.
- last update
about 1 year ago 95 pass, 6 fail - last update
about 1 year ago 95 pass, 6 fail - Status changed to Needs review
about 1 year ago 10:17am 28 March 2024 - last update
about 1 year ago 106 pass, 1 fail - 🇧🇾Belarus dewalt
If base url exists, its added one more time for Url set to form redirect. The easiest way to fix its to return destination to query bag, setting empty 'base_url' in Url object params looks tricky for me.
The last submitted patch, 5: tmgmt-use_redirect_destination_trait-3436477-4.patch, failed testing. View results →
- Status changed to Needs review
about 1 year ago 12:27pm 28 March 2024 - last update
about 1 year ago 118 pass - 🇧🇾Belarus dewalt
With this changes to use RedirectResponseSubscriber for redirects when destination is set it solves parent issue too.
Also I assume the module has issue with redirects when destination is set on sub-folder installation, looks like test doesn't cover the case. I'll check later and rename a task if needed.
- Status changed to Closed: duplicate
about 1 year ago 1:57pm 28 March 2024