LoginEvent should not be triggered if user registration failed

Created on 27 March 2024, 3 months ago

Problem/Motivation

Code in reference

$redirect = $this->userAuthenticator->authenticateUser($social_auth_user);
$event = new LoginEvent($this->currentUser(), $social_auth_user, $this->pluginId);

If for whatever reason authenticateUser fails (when trying to create account it fails some validation), LoginEvent is still triggered.

Steps to reproduce

Register with Social channel (new email, registration scenario)
Add some validation during registration (in our case, we try to invoke 3rd party API), make sure authenticateUser fails

Proposed resolution

Don't call LoginEvent and code after if authenticateUser fails

🐛 Bug report

Status

Active

Version

4.1

Component

Code

Created by

🇮🇳India gulfam_drupal

Live updates comments and jobs are added and updated live.

Merge Requests

!23LoginEvent should not be triggered if user registration failed
Open
🇮🇳India gulfam_drupal
updated 3 months ago

Comments & Activities

Issue created by @gulfam_drupal
Merge request !23LoginEvent should not be triggered at all if user registration failed. → (Open) created by gulfam_drupal
Pipeline finished with Success
3 months ago
Total: 219s
#130387
Comment 3 months ago →
🇮🇳India gulfam_drupal
Comment 3 months ago →
🇮🇳India nikunjkotecha India, Gujarat, Rajkot

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024