Inconsistency between general_settings.results and general_settings.pagesize

Created on 25 March 2024, 9 months ago
Updated 5 April 2024, 9 months ago

Problem/Motivation

I seem to have found some cases where the number of search results doesn't match the number displayed to the end user. This mucks up things like the pager.

The module schema specifies general_settings.results as the results value, so let's standardise on that.

Steps to reproduce

  1. Set general_settings.pagesize to 20
  2. Leave general_settings.results at 10
  3. Perform any search

Proposed resolution

Deprecate general_settings.pagesize and use general_settings.results for all searching and pagination operations.

Remaining tasks

Implement the change.

User interface changes

None.

API changes

None.

Data model changes

Ensure general_settings.pagesize is removed from the module entirely. Since it's not in the schema this should work out OK.

πŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia geoffreyr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024