Inconsistency between general_settings.results and general_settings.pagesize

Created on 25 March 2024, 10 months ago

Problem/Motivation

I seem to have found some cases where the number of search results doesn't match the number displayed to the end user. This mucks up things like the pager.

The module schema specifies general_settings.results as the results value, so let's standardise on that.

Steps to reproduce

Set general_settings.pagesize to 20
Leave general_settings.results at 10
Perform any search

Proposed resolution

Deprecate general_settings.pagesize and use general_settings.results for all searching and pagination operations.

Remaining tasks

Implement the change.

User interface changes

None.

API changes

None.

Data model changes

Ensure general_settings.pagesize is removed from the module entirely. Since it's not in the schema this should work out OK.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇦🇺Australia geoffreyr

Live updates comments and jobs are added and updated live.

Merge Requests

!5Inconsistency between general_settings.results and general_settings.pagesize
Open
🇦🇺Australia geoffreyr
updated 22 days ago

Comments & Activities

Issue created by @geoffreyr
Merge request !5Resolve #3435248 "Inconsistency between generalsettings.results" → (Open) created by geoffreyr
Issue was unassigned.
Status changed to Needs review 10 months ago4:29am 25 March 2024
Comment 10 months ago →
🇦🇺Australia geoffreyr
Status changed to Needs work 10 months ago8:21pm 5 April 2024
Comment 10 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Do we need a post-update hook to convert over any config that is using the old (wrong) key?
Assigned to geoffreyr
Status changed to Needs review 22 days ago3:56am 2 January 2025
Comment 22 days ago →
🇦🇺Australia geoffreyr
Updated MR with a post-update hook, as well as a module schema file.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024