- Issue created by @kim.pepper
- Merge request !75#3435020 Convert PasswordConstraint plugins to attributes → (Open) created by kim.pepper
- Status changed to Needs review
about 1 year ago 3:28am 25 March 2024 - 🇦🇺Australia mstrelan
FWIW this would need to be in a branch that requires Drupal 10.2 or higher.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I added back the annotations so we can remove in the next major.
- 🇦🇺Australia mstrelan
Unfortunately that's not enough, we'd need a backwards compatible call in PasswordConstraintPluginManager::construct to parent::construct. Currently on 10.1 we get something like this when enabling the module:
TypeError: Drupal\Core\Plugin\DefaultPluginManager::__construct(): Argument #6 ($additional_annotation_namespaces) must be of type array, string given, called in /data/app/modules/contrib/password_policy/src/PasswordConstraintPluginManager.php on line 27 in Drupal\Core\Plugin\DefaultPluginManager->__construct() (line 130 of /data/app/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php). - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I think all BC concerns have been addressed.
