- Issue created by @lostcarpark
- Merge request !92Eslint fixes - convert snake case to camel case. Also fixed indention in YML files. → (Merged) created by lostcarpark
- 🇮🇪Ireland lostcarpark
This issue reducces the total number of eslint problems from 261 to 134:
134 problems (95 errors, 39 warnings)
This only deals with camel case issues in the JS files, which should make it easy to review.
It does include some minor indentation problems in YML files, which are also reported by eslint. I felt these were minor enough, and in separate files from the camel case problems, so could be included in the same issue.
- Status changed to Needs review
about 1 year ago 11:16pm 24 March 2024 - 🇮🇪Ireland lostcarpark
Setting to needs review.
Additional issues will be created for further eslint problems.
- First commit to issue fork.
-
mandclu →
committed 165e595c on 4.1.x authored by
lostcarpark →
Issue #3433215: GitLab CI - ESLint - camel case variables
-
mandclu →
committed 165e595c on 4.1.x authored by
lostcarpark →
- Status changed to Fixed
about 1 year ago 10:18am 25 March 2024 - 🇨🇦Canada mandclu
Thanks for your work on this @lostcarpark. I have manually tested various Javascript-driven behaviour after applying these changes, and everything seems to work as before. Merged in.
- 🇮🇪Ireland lostcarpark
Actually I misrepresented the number of errors. Eslint runs twice with different parameters, and the first run returns the bigger number of errors.
Before this change, the number of errors was:
555 problems (512 errors, 43 warnings)
After, its:
385 problems (342 errors, 43 warnings)
So a solid step in the right direction, but quite a lot to do!
Automatically closed - issue fixed for 2 weeks with no activity.