- Issue created by @DamienMcKenna
- last update
10 months ago 1 pass - πΊπΈUnited States DamienMcKenna NH, USA
cspell:
The number of unrecognised/misspelled words is 13
eslint:
/builds/project/broadstreet_ads/web/modules/custom/broadstreet_ads/js/loader.js 7:29 warning Unexpected unnamed function func-names 8:3 error 'broadstreet' is not defined no-undef β 2 problems (1 error, 1 warning)
phpstan:
Line src/Plugin/Derivative/AdBlock.php ------ ---------------------------------------------------------------------- 16 \Drupal calls should be avoided in classes, use dependency injection instead
Also, the tests don't run.
- last update
10 months ago 2 fail - last update
10 months ago 2 fail - πΊπΈUnited States DamienMcKenna NH, USA
The JS comes from the official Broadstreet docs: https://information.broadstreetads.com/using-broadstreets-v2-tags/
- last update
10 months ago 2 fail - last update
10 months ago 2 fail - last update
10 months ago 1 pass - last update
10 months ago 1 pass - last update
10 months ago 1 pass - last update
10 months ago 1 pass - last update
10 months ago 1 pass - πΊπΈUnited States DamienMcKenna NH, USA
Will deal with the loader.js problem separately: π Update loader.js once Broadstreet Ads update it Active
- last update
10 months ago 1 pass -
DamienMcKenna β
committed 494e37e2 on 2.0.x
Issues #3432949 by DamienMcKenna: Improved module per gitlab-ci tests.
-
DamienMcKenna β
committed 494e37e2 on 2.0.x
- Status changed to Fixed
10 months ago 7:13pm 22 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.