Fixes for wse_scheduler

Created on 22 March 2024, 10 months ago
Updated 5 April 2024, 9 months ago

Problem/Motivation

It's been a while since wse_scheduler submodule was added and some APIs it's using have changed since. There are the following issues currently:

  • The entity query in \Drupal\wse_scheduler\ScheduledWorkspacePublisher::loadScheduledWorkspaces() is missing a call to accessCheck()
  • The instantiation of WorkspaceScheduledPublishEvent is missing the new $published_revision_ids argument
  • After enabling the module, the published_on base field is not visible on the workspace form but has to be enabled first on the manage form display form for workspaces

Steps to reproduce

On vanilla Drupal 10.2.x

  • Enable wse_scheduler
  • Add a workspace and add some content to it
  • Edit the workpspace and set the "Publish on" field to a date in the past
  • Run the drush command wsesp or trigger a cron run
🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Pipeline finished with Skipped
    over 1 year ago
    #12106
  • Pipeline finished with Skipped
    over 1 year ago
    #17170
  • Pipeline finished with Success
    about 1 year ago
    Total: 143s
    #50321
  • Issue created by @s_leu
  • At some point we might also want to drop the \Drupal\wse_scheduler\Event\WorkspaceSchedulerEvents class and use the event class name. I didn't want to do this yet as it might breaking changes on some sites that subscribe to the event.

  • Status changed to RTBC 10 months ago
  • 🇷🇴Romania amateescu

    The MR looks good to me :)

    • s_leu committed cb96c4e4 on 1.0.x
      Issue #3432910 by s_leu, amateescu: Fixes for wse_scheduler
      
  • Status changed to Fixed 10 months ago
  • Thanks for the quick review, merged.

  • Pipeline finished with Success
    10 months ago
    Total: 832s
    #128036
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Canceled
    9 months ago
    Total: 53s
    #143213
  • Pipeline finished with Success
    9 months ago
    Total: 217s
    #143215
  • Pipeline finished with Success
    9 months ago
    Total: 148s
    #144075
  • Pipeline finished with Success
    9 months ago
    #144092
  • Pipeline finished with Success
    9 months ago
    Total: 303s
    #144098
  • Pipeline finished with Failed
    8 months ago
    Total: 173s
    #169787
  • Pipeline finished with Success
    8 months ago
    Total: 166s
    #169900
  • Pipeline finished with Success
    8 months ago
    Total: 202s
    #169907
  • Pipeline finished with Success
    8 months ago
    #171139
  • Pipeline finished with Failed
    8 months ago
    Total: 197s
    #171195
  • Pipeline finished with Failed
    8 months ago
    Total: 204s
    #171462
  • Pipeline finished with Failed
    8 months ago
    Total: 168s
    #171528
  • Pipeline finished with Failed
    8 months ago
    #171535
  • Pipeline finished with Failed
    8 months ago
    #171542
  • Pipeline finished with Canceled
    8 months ago
    Total: 75s
    #171547
  • Pipeline finished with Failed
    8 months ago
    Total: 174s
    #171550
  • Pipeline finished with Canceled
    8 months ago
    Total: 102s
    #171552
  • Pipeline finished with Success
    8 months ago
    Total: 257s
    #171554
  • Pipeline finished with Success
    8 months ago
    #171560
  • Pipeline finished with Failed
    8 months ago
    Total: 3691s
    #171829
  • Pipeline finished with Failed
    8 months ago
    Total: 3692s
    #172244
  • Pipeline finished with Failed
    8 months ago
    Total: 3694s
    #172247
  • Pipeline finished with Success
    8 months ago
    Total: 220s
    #175936
  • Pipeline finished with Failed
    8 months ago
    Total: 135s
    #179421
  • Pipeline finished with Failed
    8 months ago
    Total: 184s
    #179426
  • Pipeline finished with Success
    7 months ago
    Total: 499s
    #192664
  • Pipeline finished with Skipped
    7 months ago
    #193929
  • Pipeline finished with Success
    7 months ago
    Total: 275s
    #198563
  • Pipeline finished with Success
    7 months ago
    Total: 268s
    #198566
  • Pipeline finished with Success
    7 months ago
    Total: 192s
    #198681
  • Pipeline finished with Success
    7 months ago
    #198765
  • Pipeline finished with Success
    7 months ago
    #201266
  • Pipeline finished with Skipped
    7 months ago
    #203597
  • Pipeline finished with Failed
    7 months ago
    Total: 4861s
    #203692
  • Pipeline finished with Canceled
    7 months ago
    Total: 105s
    #204198
  • Pipeline finished with Manual
    7 months ago
    #204202
  • Pipeline finished with Failed
    7 months ago
    Total: 170s
    #205316
  • Pipeline finished with Failed
    7 months ago
    Total: 239s
    #205323
  • Pipeline finished with Success
    6 months ago
    #210922
  • Pipeline finished with Canceled
    6 months ago
    Total: 7s
    #210931
  • Pipeline finished with Success
    6 months ago
    Total: 240s
    #212859
  • Pipeline finished with Success
    6 months ago
    Total: 210s
    #212874
  • Pipeline finished with Success
    6 months ago
    Total: 180s
    #212924
  • Pipeline finished with Success
    6 months ago
    Total: 186s
    #212932
Production build 0.71.5 2024