- Issue created by @chadhester
- Status changed to Needs review
8 months ago 5:00pm 25 March 2024 - πΊπΈUnited States chadhester
I may need to create a separate issue to handle the missing schema definition, which causes an error when running this test.
- Issue was unassigned.
- πΊπΈUnited States chadhester
Confirming that an error is thrown if the test is run:
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for field.field.node.smart_date_content.field_date with the following errors: field.field.node.smart_date_content.field_date:default_value.0.default_end_date_type missing schema, field.field.node.smart_date_content.field_date:default_value.0.default_end_date missing schema
I can put the fix in another dependent issue:
chadhester@example-d10-web:/var/www/html/web/modules/contrib/smart_date$ git diff config/schema/smart_date.schema.yml diff --git a/config/schema/smart_date.schema.yml b/config/schema/smart_date.schema.yml index 53d9410..930e05d 100644 --- a/config/schema/smart_date.schema.yml +++ b/config/schema/smart_date.schema.yml @@ -38,6 +38,12 @@ field.value.smartdate: default_date: type: string label: 'Default start date value' + default_end_date_type: + type: string + label: 'Default end date type' + default_end_date: + type: string + label: 'Default end date value' min: type: string label: 'Minimum Date'
- First commit to issue fork.
- Status changed to RTBC
8 months ago 7:59pm 26 March 2024 - πΊπΈUnited States nicxvan
This test looks great to me.
I resolved my last comment by updating sooner to earlier for minor semantic reasons, I didn't want to block progress on this for that issue.Assuming tests still pass, I'm marking this as RTBC.
- First commit to issue fork.
-
mandclu β
committed 4c35ed4f on 4.1.x authored by
chadhester β
Issue #3432819 by chadhester, nicxvan, ultimike: Test for a later start...
-
mandclu β
committed 4c35ed4f on 4.1.x authored by
chadhester β
- Status changed to Fixed
8 months ago 11:34am 27 March 2024 - πΊπΈUnited States ultimike Florida, USA
mandclu β credited ultimike β .
- π¨π¦Canada mandclu
This has been merged in. Thanks for everyone's work on this!
Automatically closed - issue fixed for 2 weeks with no activity.