[beta6] Some little fixes in header, footer & page layout

Created on 21 March 2024, 3 months ago
Updated 6 April 2024, 3 months ago

Header, footer & page layout

Left and sidebar: add container

We have those 2 regions:

  sidebar_first: Sidebar - First
  sidebar_second: Sidebar - Second

They are printed in page.html.twig

However, they are not displayed as proper sidebars. We need to use the DSFR grid into page.html.twig

Useless page.logo variable?

in page.html.twig, there is a page.logo variable:

  {{ pattern('header', {
    'logo_text': page.logo,

But there are no "logo" region:

regions:
  header_operator_logo: Header - Operator logo
  header_tools_links: Header - Tools links
  header_tools_search: Header - Tools search
  header_navbar: Header - Navbar
  content: Content
  sidebar_first: Sidebar - First
  sidebar_second: Sidebar - Second
  footer_operator_logo: Footer - Operator logo
  footer_content: Footer - Content
  footer_content_desc: Footer - Content description
  footer_partners: Footer - Partners
  footer_bottom: Footer - Bottom
  footer_bottom_copy: Footer - Bottom copy

We don't want such a region, because logo_text is a string prop, not a slot.

header & footer: configurable logo_text

The replacement value of logo_text will be taken from a new textfield theme setting.

Default value for container in theme settings?

After the installation of the theme, there is no container. Would it look cleaner to have the fixed container by default?

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024