updateFacetsBlocks should not send a request if there is no facet block

Created on 21 March 2024, 8 months ago

Problem/Motivation

The updateFacetsBlocks JS function sends its request even if we know that the Ajax call will result in a 404 error because \Drupal\facets\Controller\FacetBlockAjaxController::ajaxFacetBlockView() throws a \Symfony\Component\HttpKernel\Exception\NotFoundHttpException when $path or $facets_blocks are empty.

This can happen when using custom facets rendering that uses Ajax to update (without being blocks).

Proposed resolution

Add a simple test before sending the request to prevent error.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇫🇷France duaelfr Montpellier, France

Live updates comments and jobs are added and updated live.

Merge Requests

!192updateFacetsBlocks should not send a request if there is no facet block
Open
🇮🇳India rakesh.regar
updated 8 months ago

Comments & Activities

Issue created by @duaelfr
Status changed to Needs review 8 months ago1:17pm 21 March 2024
Comment 8 months ago →
🇫🇷France duaelfr Montpellier, France
Patch is really simple and causes no harm :)
Comment 8 months ago →
🇮🇳India rakesh.regar Rajasthan, India
rakesh.regar → made their first commit to this issue’s fork.
Merge request !192Issue #3432718 Update Facets block should not send a request. → (Open) created by rakesh.regar
Comment 8 months ago →
🇮🇳India rakesh.regar Rajasthan, India
Raised merge request with patch #2
Pipeline finished with Failed
8 months ago
Total: 675s
#125194

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

updateFacetsBlocks should not send a request if there is no facet block

Problem/Motivation

Proposed resolution

Merge Requests

!192updateFacetsBlocks should not send a request if there is no facet blockOpen

Comments & Activities

!192updateFacetsBlocks should not send a request if there is no facet block
Open