MR comments and updates not displayed due to JS error

Code needs review. This page is using that code https://fjgarlin-drupal.dev.devdrupal.org/project/config_notify/issues/3..., but as it's an edge case I'm not sure we're testing that particular edge case. In any case, the change seemed really straightforward.

On the dev site, Toggle MR Activity works as expected, and it even shows the number of comments that would be shown/hidden.
I checked https://fjgarlin-drupal.dev.devdrupal.org/project/config_notify/issues/3... as anonymous user, if that makes any difference.

I did not anticipate this.
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')

So it seems like sometimes afterComment is completely null or undefined.
Maybe we can do something like this (though I don't get why it's fully empty or undefined in this case):

if (!afterComment) {
  afterComment = {};
}

fjgarlin → changed the visibility of the branch 7.x-3.x to hidden.

Created new MR https://git.drupalcode.org/project/drupalorg/-/merge_requests/235 with #7.

We’re assuming all MR activity happens after the first issue comment. GitLab seems to have pulled in “@mloayza commented on commit 151669b7 2 years ago” on https://git.drupalcode.org/project/globallink/-/merge_requests/3.

So we either discard that MR note, or set afterComment to the earliest element of comments

The second fix is deployed & confirmed working now.

Automatically closed - issue fixed for 2 weeks with no activity.