- Issue created by @mondrake
- 🇮🇹Italy mondrake 🇮🇹
If we can accept
dump()
to write to STDERR, this seems easy to fix. - Status changed to Needs review
9 months ago 5:14pm 20 March 2024 - Status changed to RTBC
8 months ago 6:20pm 25 March 2024 - 🇺🇸United States smustgrave
If this is just targetting D11, which requires 8.3, don't see an issue with the change.
- 🇬🇧United Kingdom longwave UK
This should be backported given that developers will also run tests on PHP 8.3 on Drupal 10.
Unsure if it's worth a change record, 99% will not notice the difference, the only thing I can see it affecting is if someone is redirecting output in a shell script or similar?
- 🇬🇧United Kingdom catch
I don't think this is worth a change record, if someone turns out to be affected by this, they're unlikely to find out via the change record anyway I would think.
- 🇮🇹Italy mondrake 🇮🇹
Later when we will have let PHPUnit 9 go, we may consider doing this differently, capturing the dump in a cache and actually printing it as part of the end test event, when the test is actually closed. Instead of using the STD streams that (both OUT and ERR), quite understandably, PHPUnit wants to advocate as part of the SUT, and therefore not mix with test code. At that point yes, a CR would do. But, please, PHPUnit 10+… I wouldn’t tamper with long dead listeners.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 80139bdb8e to 11.x and 5e7ac12c4d to 10.3.x. Thanks!
I think we should backport this to 10.2 because it's really annoying and I'm not really sure there is a bc impact. Relying on the output of dump() feels v wrong.
-
alexpott →
committed 5e7ac12c on 10.3.x
Issue #3432171 by mondrake: dump() no longer produces output in PHPUnit...
-
alexpott →
committed 5e7ac12c on 10.3.x
- Status changed to Downport
8 months ago 11:03pm 25 March 2024 -
alexpott →
committed 80139bdb on 11.x
Issue #3432171 by mondrake: dump() no longer produces output in PHPUnit...
-
alexpott →
committed 80139bdb on 11.x
- 🇮🇹Italy mondrake 🇮🇹
Filed 📌 [PHPUnit 10+ only] Make dump() output in tests no longer use standard streams Needs review for follow up.
-
longwave →
committed 321dc38a on 10.2.x authored by
alexpott →
Issue #3432171 by mondrake: dump() no longer produces output in PHPUnit...
-
longwave →
committed 321dc38a on 10.2.x authored by
alexpott →
- Status changed to Fixed
8 months ago 10:34am 26 March 2024 - 🇬🇧United Kingdom longwave UK
Agreed, backported to 10.2.x as this is tests-only and solves a PHP compatibility issue.
Automatically closed - issue fixed for 2 weeks with no activity.