- Issue created by @jonathan1055
- π¬π§United Kingdom jonathan1055
I am going to use this issue as test for the upcoming gitlab_templates changes on #3426136: Execute CSPELL in project root folder and make fixing words easier β
- π¬π§United Kingdom jonathan1055
Baseline starting point is
CSpell: Files checked: 43, Issues found: 36 in 10 files The number of unrecognised/misspelled words is 20
- π¬π§United Kingdom jonathan1055
The first commit add a word, but without extra quotes. The job should fail as this is currently incorrect with the existing cspell job.
- π¬π§United Kingdom jonathan1055
As expected we get the failure
Configuration Error: Failed to read config file: "/builds/issue/module_filter-3431234/gitlabci_cspell/module_filter-3431234/.cspell.json" CSpell: Files checked: 0, Issues found: 0 in 0 files
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1092051
Next commit will use the changes in the gitlab_templates MR155
- π¬π§United Kingdom jonathan1055
With MR155 the cspell jobs runs correctly.
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1092554CSpell: Files checked: 42, Issues found: 30 in 9 files The number of unrecognised/misspelled words is 18 An artifact file has been created containing a unique list of these unrecognized words, for you to browse or download. === This is _cspell_unrecognized_words.txt === aname Andrey andrey bname ctools demonstates desciption dispayed initialise interdif Mustgrave Permisions reclosed smustgrave toco Troeglazov troeglazov untain
42 files checked instead of 43. Composer.json is now automatically ignored. The single word 'nana' in _CSPELL_WORDS is no longer reported.
- π¬π§United Kingdom jonathan1055
The last commit added two more words and ignored the 'maintainers' paragraph in README.md
Spell: Files checked: 42, Issues found: 18 in 8 files The number of unrecognised/misspelled words is 10 An artifact file has been created containing a unique list of these unrecognized words, for you to browse or download. === This is _cspell_unrecognized_words.txt === aname bname ctools demonstates desciption dispayed initialise interdif Permisions reclosed
- π¬π§United Kingdom jonathan1055
Added two drupal/programming terms
ctools, interdif
to _cspell_words, and changed two variable names to camelCase.https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1093117
Now we are just left with the real spelling errors:
CSpell: Files checked: 42, Issues found: 9 in 5 files The number of unrecognised/misspelled words is 6 An artifact file has been created containing a unique list of these unrecognized words, for you to browse or download. === This is _cspell_unrecognized_words.txt === demonstates desciption dispayed initialise Permisions reclosed
- π¬π§United Kingdom jonathan1055
The cspell job passes green
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1093197CSpell: Files checked: 41, Issues found: 0 in 0 files
- π¬π§United Kingdom jonathan1055
The spelling fixes are all done, but this is still using the MR155 from gitlab_templates issue #3426136: Execute CSPELL in project root folder and make fixing words easier β
We need to wait for that to be merged, and then also wait for those changes to reach the 'default-ref' tag, which is the equivalent of a stable recommended release.
- Status changed to Needs review
about 1 year ago 12:00pm 28 March 2024 - π¬π§United Kingdom jonathan1055
#3426136: Execute CSPELL in project root folder and make fixing words easier β has been committed.
Also the gitlab_templates
default-ref
tag has been updated to include this change for all contrib by default. Hence I have reverted the temporary change here.The CSPELL job ends green. This is ready for review.
-
smustgrave β
committed 7544dbb6 on 4.x authored by
jonathan1055 β
Issue #3431234: Fix spelling
-
smustgrave β
committed 7544dbb6 on 4.x authored by
jonathan1055 β
- πΊπΈUnited States smustgrave
Fine with all the word changes. Didn't think about the disable for the names I've added my name to the cpsell ignore txt file on other projects haha.
- Status changed to Fixed
about 1 year ago 2:14pm 1 April 2024 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.