Resuming a failed script run is off by one

Open on Drupal.org →

Created on 18 March 2024, 9 months ago

Updated 19 March 2024, 9 months ago

Problem/Motivation

If the run of the batch fails at item 5 meaning 4 was successful, running the script again causes it to start at 4 instead of 5.

I trouble shot this a bit, but it seems to be saving the right number in state, but then if the script fails, there is sometimes a db transaction rollback and so the number saved, changes to become the previous. This may or may not happen for all types of failures.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States swirt Florida

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @swirt
Comment 9 months ago →
🇺🇸United States swirt Florida

Comment 9 months ago →

swirt → committed f983b452 on 1.0.x

Issue #3431217 by swirt: Resuming a failed script run is off by one

Status changed to Fixed 9 months ago2:23am 19 March 2024
Comment 9 months ago →
🇺🇸United States swirt Florida
It turns out the processing was not off by one, but the messaging made it seem as though it was. I have cleaned up the timing of the messaging to make it clearer about when errors are happening and where the script is resuming.

This will go out with alpha2
Status changed to Fixed 9 months ago3:21am 19 March 2024
Comment 9 months ago →
🇺🇸United States swirt Florida
Released alpha2

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024