- Issue created by @Andrii Momotov
- Assigned to Andrii Momotov
- Issue was unassigned.
- Status changed to Needs review
8 months ago 10:06pm 16 March 2024 - πΊπ¦Ukraine Andrii Momotov
Added composer.json file. Please review. Thanks!
- π§π·Brazil luco
hello Andrii,
thank you so much for taking the time to work on my humble module! your input in invaluable for me to further my learning.
I wasn't aware that a composer.json file is needed. did the tests or anything else break without it? would you please link me with the docs outlining this requirement?
best regards,
Luciano - πΊπ¦Ukraine Andrii Momotov
Hi Luciano,
In our case, it's not required to add a composer.json file to the module, it's according to your wishes. Here are several scenarios where it is required:
https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file βBut if in the future you decide to extend the module in any way, you won't need to create this file because it will already exist :)
In addition, adding this file opens up several possibilities that are described in the article linked above.
Don't worry, the presence of this file will not affect the functionality of the module in any way.Thanks!
-
luco β
committed 5c3c1e82 on tardis-3429600-3429600-add-composer.json-file authored by
Andrii Momotov β
Issue #3429600: Add composer.json file
-
luco β
committed 5c3c1e82 on tardis-3429600-3429600-add-composer.json-file authored by
Andrii Momotov β
-
luco β
committed fa03d282 on 4.0.x authored by
Andrii Momotov β
Issue #3429600: Add composer.json file
-
luco β
committed fa03d282 on 4.0.x authored by
Andrii Momotov β
- π§π·Brazil luco
I see... not needed, but it's for "the wider PHP community". for me that's justification enough π
I've added the file - should be present in the next build. thank you! please test and let me know once done.
best regards,
Luciano - πΊπ¦Ukraine Andrii Momotov
Hi Luciano,
I would like to clarify. Are you asking me to test it when it's in the new release, or are you asking to test it on the 4.0.x branch right now?
Thank you!
- π§π·Brazil luco
hi Andrii,
please test right away by removing the module and requiring it once more, in a testing environment.
best regards,
Luciano - πΊπ¦Ukraine Andrii Momotov
Hi Luciano,
I have tested it in a testing environment and everything is ok.
Thank you!
- Status changed to Fixed
8 months ago 3:50pm 26 March 2024 - π§π·Brazil luco
excellent, thank you!
I'm closing this ticket, but feel free to reopen it in case of any issues.
best regards,
Luciano Automatically closed - issue fixed for 2 weeks with no activity.