- Issue created by @HeneryH
- 🇺🇸United States HeneryH
In the short term, I just removed the hardcoded navbar height and rebuilt the subtheme.
I'm a fan of shrinking the image to fit the hardcoded sccs navbar height as a safety feature. I can't think of any case where we would not want the logo height capped to avoid clipping. I'm going to go try to find the proper sccs code to do that now and rebuild my sub-theme.
- Status changed to Closed: won't fix
9 months ago 10:35am 16 March 2024 - 🇯🇴Jordan Rajab Natshah Jordan
1. Please, do not use sub theme method. ( stop using old logic and old thinking )
2. Do your custom work and changes for your custom cloned theme. ( Not going to add your custom in Varbase )
3. Copy all componnets and custimize them for your project.Working in the following for Vardot and Varbase needs only
- 📌 Change Default implementation for a Page Header and the Navbar components to follow with Varbase Design System Active
- 📌 Add new Branding Logo component following Drupal ~10.1.0 and Bootstrap ~5.3.0 Active
- 📌 Add the new Varbase white logo svg file and logo_white patch variable Active
A starterkit theme for Varbase → standard websites.
A new generation of theming based on Bootstrap 5, Single Directory Components (SDC) with Drupal ~10 → , and UI Patterns → .
Having Varbase Components → to provides component management system for Varbase and Vartheme BS5.
Theme Development tools- Moving from old ways to new generative ways.
- Moving to use Single Directory Components (SDC) which all components are listed in Varbase Components →
- Moving to support Storybook in Varbase Projects
- No support for sub-themes, Only Generate your custom cloned theme from the Vartheme BS5 Starter kit.
Do not think of Vartheme BS5 as a base theme, It is a starter kit theme. It has template mapping with Single Directory Components.
Theme Development with VarbaseFollowing with Varbase Design System
- 🇺🇸United States HeneryH
Well, I think that requiring logos to be under a maximum pixel height in order to display properly is a poor design.
In your method, one must customize the theme and rebuild it in order to adjust for varying logo heights.
But, hey, whatever.