Drupal 10 compatibility

Created on 14 March 2024, 9 months ago
Updated 3 May 2024, 8 months ago

Problem/Motivation

The module is not compatible with Drupal 10:

  1. The .info.yml file doesn't indicate Drupal 10 compatibility
  2. The module makes use of jQuery.once() which has been deprecated β†’

Steps to reproduce

  1. Note that the .info.yml file does not include Drupal 10 among its core_version_requirement options
  2. Create a page (that isn't the page at the path '/') with a link to '/user/login'
  3. Note the path for that page
  4. Navigate to that page with this module installed and not patched
  5. Note js error in your console: Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach

Proposed resolution

  • Update core_version_requirement to include Drupal 10
  • Remove dependencies on core/jquery and core/jquery.once; add dependency on core/once
  • Update logic in login_return_page.js to use core/once

Remaining tasks

Patch forthcoming.

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States COBadger

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024