- Issue created by @thejimbirch
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Example issue of this done is
Convert EntityReferenceSelection plugin discovery to attributes
https://www.drupal.org/project/drupal/issues/3420982 📌 Convert EntityReferenceSelection plugin discovery to attributes Needs work - First commit to issue fork.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 4:02pm 19 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
@srishtiiee I'm so sorry I only noticed you working on this after I started. There was a funny bug caused by DuplicateConfigAction being in the wrong namespace. Only hit us now because annotations doesn't actually load the code whereas using attributes does.
- Status changed to Needs work
3 months ago 5:06pm 19 March 2024 - 🇺🇸United States phenaproxima Massachusetts
A few minor points but consider this an RTBC once they're addressed.
- Status changed to Needs review
3 months ago 5:27pm 19 March 2024 - Status changed to Needs work
3 months ago 7:33pm 19 March 2024 - 🇺🇸United States phenaproxima Massachusetts
Minor suggestion on the new exception (which seems like a good idea). I would suggest using a different exception class.
- Status changed to Needs review
3 months ago 10:23pm 22 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Symfony uses sprintf() in exceptions... just tend copy them. Not sure why they do that.
- Status changed to RTBC
3 months ago 2:07am 23 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 9e17ecd2ad7 to 11.x and d5049df653f to 10.3.x. Thanks!
-
alexpott →
committed d5049df6 on 10.3.x
Issue #3427874 by alexpott, phenaproxima: Move all ConfigAction...
-
alexpott →
committed d5049df6 on 10.3.x
- Status changed to Fixed
3 months ago 9:29am 23 March 2024 -
alexpott →
committed 9e17ecd2 on 11.x
Issue #3427874 by alexpott, phenaproxima: Move all ConfigAction...
-
alexpott →
committed 9e17ecd2 on 11.x
- 3a571b0b committed on patch
Update recipe 11.x patch 9e17ecd2 Issue #3427874 by alexpott,...
- 3a571b0b committed on patch
- 1cef2834 committed on patch
Update recipe 10.3.x patch d5049df6 Issue #3427874 by alexpott,...
- 1cef2834 committed on patch
Automatically closed - issue fixed for 2 weeks with no activity.