Contrib.social

SimpleFieldMapper produces extra null value

Open on Drupal.org →
Created on 12 March 2024, 11 months ago

Problem/Motivation

When evaluating a selector for a multi-valued field, SimpleFieldMapper will generate an extra "null" value.

Steps to reproduce

{
  "events": [
    {"id": "a", title: "foo"},
    {"id": "b", title: "bar"}
  ]
}
  1. Retrieve an external entity with a multi-valued field, e.g. "events".
  2. Configure a simple field mapping: events/*/id
  3. SimpleFieldMapper will incorrectly return ["a", "b", null]

Proposed resolution

Fix off-by-one error in for loop.

Remaining tasks

Code review.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany rob_pr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024