Contrib.social

UserNavigationBlock implementation makes all pages uncacheable

Open on Drupal.org →
Created on 11 March 2024, 10 months ago
Updated 1 April 2024, 9 months ago

Problem/Motivation

Inspired by 🐛 Shortcut hook_toolbar implementation makes all pages uncacheable Fixed & 🐛 ShortcutsNavigationBlock does not take into account the user's default shortcut set Active , we found that the way UserNavigationBlock is implemented, pages are not being cached properly. This causes the Dynamic page cache to stop working, since the cardinality is too high.

Steps to reproduce

Proposed resolution

Implement a Lazy Builder to use a cached placeholder for UserNavigationBlock

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Comment 10 months ago →
    🇪🇸Spain plopesc Valladolid
  • Merge request !189Issue #3427114: UserNavigationBlock implementation makes all pages uncacheable → (Merged) created by plopesc
  • Pipeline finished with Success
    10 months ago
    Total: 144s
    #116623
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇪🇸Spain plopesc Valladolid

    MR created

  • Pipeline finished with Failed
    9 months ago
    Total: 633s
    #120433
  • First commit to issue fork.
  • Pipeline finished with Success
    9 months ago
    Total: 146s
    #120528
  • Pipeline finished with Success
    9 months ago
    Total: 146s
    #120531
  • Issue was unassigned.
  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇨🇦Canada m4olivei Grimsby, ON

    Looks great! I just added in some coding standards fixes to move us along. phpcs is happy now. RTBC.

  • Pipeline finished with Failed
    9 months ago
    Total: 618s
    #120655
  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇪🇸Spain ckrina Barcelona

    Merged, thanks!

  • Pipeline finished with Success
    9 months ago
    Total: 142s
    #122136
  • Comment 9 months ago →
    System Message
  • Pipeline finished with Failed
    9 months ago
    Total: 666s
    #127587
  • Pipeline finished with Failed
    9 months ago
    Total: 663s
    #127809
  • Comment 9 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    7 months ago
    Total: 151s
    #192755
  • Pipeline finished with Success
    7 months ago
    Total: 174s
    #192763
  • Pipeline finished with Success
    4 months ago
    Total: 513s
    #254884
  • Pipeline finished with Success
    4 months ago
    Total: 2597s
    #254891
  • Pipeline finished with Success
    4 months ago
    Total: 1154s
    #255195
  • Pipeline finished with Skipped
    4 months ago
    #255296
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024