- Issue created by @sokru
- 🇨🇦Canada mparker17 UTC-4
I'm not certain how useful this is going to be in this situation, but when I plan out D6/D7 -> D10 migrations, I make a table of "new" (D10) configuration and figure out how to get it from the "old" (D7) configuration... so below is a table of how
elasticsearch_connector-8.0.x
server configuration maps toelasticsearch_connector-8.x-7.x
configuration. Note that I still need to figure out how the index configuration maps.Note that you can get the
$CLUSTER_ID
from the 8.x-7.xsearch_api.server.$SERVER_ID
configuration by looking at the config with the keybackend_config.cluster_settings.cluster
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Status changed to Needs work
9 months ago 10:06pm 16 March 2024 - 🇨🇦Canada mparker17 UTC-4
I've made some progress on the Server/Cluster configuration migrations; but I still need to figure out the Index migrations, so I'm leaving this as "needs work"
Does anyone offhand know of any part of core or contrib that tests configuration migrations between major versions? If so, I would very much like to see an example, so I can write tests here.
- 🇨🇦Canada mparker17 UTC-4
Adding 🌱 Plan for 8.0.0-alpha release Active as a parent issue.
- 🇫🇮Finland sokru
Here's few examples for configuration migration tests:
https://git.drupalcode.org/project/metatag/-/blob/2.0.x/tests/src/Functi...
https://git.drupalcode.org/project/search_api/-/blob/8.x-1.x/modules/sea...
https://git.drupalcode.org/project/feeds/-/blob/8.x-3.x/tests/src/Functi... - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Status changed to Needs review
9 months ago 3:40pm 22 March 2024 - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - 🇨🇦Canada mparker17 UTC-4
Out of curiosity, I tried deleting the deprecated config schema definitions, but tests failed: https://git.drupalcode.org/project/elasticsearch_connector/-/jobs/1138070 - so I've put back the deprecated config schema definitions.
- 🇫🇮Finland sokru
The requirement for deprecated configs needs to come from core. Sorry for the hassle, lets keep them.
After handling the prefix I think we should merge this and create issue(s) for 8.x-7.x branch and deprecate the hooks and Events. Scope of the issue would just mark them deprecated and on change record describe how the EventSubscribers should be changed when updating to 8.0.x.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - 🇫🇮Finland sokru
I was about to merge the MR, since it would be much easier to test on different projects if the upgrade path would be on -dev, but then I started to think if we should also add the suffix option. When the prefix+suffix was added on #3010955: Allow index name flexibility → it was argued that it makes easier to alter the index for different environments eg.
$config['elasticsearch_connector.cluster.cluster_name']['options']['rewrite']['index']['suffix'] = '_test_env';
not sure if there is an easy alternative now to accomplish the same...
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - 🇨🇦Canada mparker17 UTC-4
@sokru, Thanks for your patience with me!
I have added support for an index suffix to the module in the latest changes, and updated the migration and migration tests accordingly!
- Status changed to Fixed
9 months ago 12:40pm 6 April 2024 - 🇫🇮Finland sokru
@marpker17 Thanks! I'll merge this now so its easier to test upgrade process with custom eventsubscribers. The remaining task is to update change record [#3433223], but I'd say its more related to 🌱 Plan for 8.0.0-alpha release Active , so marking this "Fixed".
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass -
sokru →
committed 3d8258ab on 8.0.x authored by
mparker17 →
Issue #3426828 by mparker17, sokru: Upgrade path from 8.x-7.x branch
-
sokru →
committed 3d8258ab on 8.0.x authored by
mparker17 →
Automatically closed - issue fixed for 2 weeks with no activity.