is_numeric check after augmentOutput() fails for core date field type using smart date formatter

Thanks for identifying this, and for suggesting a fix. The approach you've taken seems sensible enough, but I wonder if it wouldn't be better to update the call to augmentOutput() within SmartDateTrait::viewElements to pass in the calculated $start_ts and $end_ts values instead (or maybe in addition?).

The original code looks like it did that, which makes me think there's a reason I decided not when this was refactored. A year later, however, I don't seem to have any notes on that.

I'm inclined to want to test that first, to see if there's an obvious reason why using the $start_ts and $end_ts values already calculated wouldn't be a better approach.

After giving this some more thought, it only makes sense to ensure the values are numeric without the augmentOutput method, whether or not the method should be fed the original, unaltered values. I added a todo to revisit that question, and also moved the code that normalizes the values before the loop. Merged in.

Automatically closed - issue fixed for 2 weeks with no activity.