More Advanced Gitlab pipeline

The tests past, except for the dev release of pdf api.

The issue with pdf_api is small. It is addressed in this issue:
📌 No schema for pdf_api.dom_pdf.settings Needs review

This tests the current version of Drupal and:

• The previous major release
• The previous minor release
• The next minor release
• The current version of Drupal and the Dev version of pdf api

I had to make some changes to get the code to run on Drupal 9.

Thanks! I'll seek to get that issue fixed and merge this.

Why the move away from constructor property promotion?

The constructors caused issues with Drupal 9.

ParseError: syntax error, unexpected 'protected' (T_PROTECTED), expecting
variable (T_VARIABLE)

https://git.drupalcode.org/issue/printable-3426662/-/jobs/1048660

Hmm, PHP 7 still perhaps?

According to https://www.drupal.org/docs/getting-started/system-requirements/php-requ... → , the only supported version of 9 is 9.5, and that requires PHP 8 so I think we should be safe with them.

I updated just the pipeline and tests fail for the previous major version of Drupal. The CI pipeline uses php 7.4, this setting is controlled by a Drupal team. Drupal 9 testing is controlled by:

variables:
  OPT_IN_TEST_PREVIOUS_MAJOR: 1

I didn't change the constructor for personal preference. This is your project.

Do you want me to revert the constructor changes, and remove testing for Drupal 9?

https://git.drupalcode.org/issue/printable-3426662/-/pipelines/117500

Drupal version : 9.5.11
Site URI : http://default
PHP binary : /usr/local/bin/php
PHP config : /usr/local/etc/php/php-cli.ini
PHP OS : Linux
PHP version : 7.4.28
Drush script : /builds/issue/printable-3426662/vendor/bin/drush
Drush version : 11.6.0
Drush temp : /tmp
Drush configs : /builds/issue/printable-3426662/vendor/drush/drush/drush.ym
l
Drupal root : /builds/issue/printable-3426662/web
Site path : sites/default

Thanks for the reply!

My thinking is that we should support current versions, which would mean 9.5 and 10. Assuming you agree - although I'm maintaining it, I don't think I should be autocratic! - I'd suggest looking at whether we can tell the CI pipeline to use PHP 8 and Drupal 9.5. If it insists on 7, perhaps we should drop testing 9 for now. Does that sound reasonable?

Regards,

Nigel

I am not an expert on GitLab CI pipelines, but I am learning.

The PHP version is controlled by the `CORE_PREVIOUS_PHP_MIN` variable. I think it can be changed to 8.0.

I am reluctant to change the variable. It will need to be changed again when Drupal 11 is released. How many more releases of Drupal 10 will there be? I have received automated Drupal 11 patches for other projects.

The printable dev release supports 9.4. Drupal 9.4 still supports Php7.4. If 9.4 is a supported Core, there should be tests with php7.4, if not Core 9.4. Maybe I should add tests for Drupal 9.4?

The changes are small. I recommend you accept the changes to the constructors and drop support for Drupal 9 when Drupal 11 is released.

If you want to drop support for Drupal 9.4, or all of Drupal 9, now I can update the pipeline and the requirements.

Let's drop support for Drupal 9.4. It's not supported by core anymore so I think we have good justification.