Gitlab CI - PHPCS - Return comments and Class comments

-------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY -------------------------------------------------------------------------------- SOURCE COUNT -------------------------------------------------------------------------------- [ ] Drupal.Commenting.FunctionComment.MissingReturnComment 5 [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl 5 [x] Drupal.Commenting.ClassComment.Missing 3 [ ] Drupal.Semantics.FunctionT.NotLiteralString 3 [ ] Drupal.Commenting.FunctionComment.MissingParamType 1 [ ] Drupal.NamingConventions.ValidFunctionName.InvalidPrefix 1 [ ] Generic.CodeAnalysis.UselessOverridingMethod.Found 1 [ ] Squiz.Arrays.ArrayDeclaration.NoKeySpecified 1 -------------------------------------------------------------------------------- A TOTAL OF 20 SNIFF VIOLATIONS WERE FOUND IN 8 SOURCES --------------------------------------------------------------------------------

Comments & Activities

Issue created by @lostcarpark
Merge request !443PHPCS fixes for class comments and return type comments. → (Merged) created by lostcarpark
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
86 pass
Pipeline finished with Success
10 months ago
Total: 650s
#114914
Status changed to Needs review 10 months ago3:50pm 8 March 2024
Comment 10 months ago →
🇮🇪Ireland lostcarpark
Provided comments for return types and classes.

Noticed a minor wording mistake in the function comment for ProjectBrowserSourceInterface::getDevelopmentOptions, so fixed that as well.
Status changed to RTBC 10 months ago3:57pm 8 March 2024
Comment 10 months ago →
🇺🇸United States tim.plunkett Philadelphia
Looks good, thanks
Pipeline finished with Skipped
10 months ago
#115082
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
79 pass, 1 fail
First commit to issue fork.
Pipeline finished with Skipped
10 months ago
#115083
Comment 10 months ago →
System Message

chrisfromredfin → committed f4fed6eb on 1.0.x authored by lostcarpark →
Issue #3426658: Gitlab CI - PHPCS - Return comments and Class comments
Status changed to Fixed 10 months ago7:34pm 8 March 2024
Comment 10 months ago →
🇺🇸United States chrisfromredfin Portland, Maine
Choo, choo! Adding this to the Merge Train. 🚂

We're so close to GitLab CI I can taste it.
Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Gitlab CI - PHPCS - Return comments and Class comments

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!443Gitlab CI - PHPCS - Return comments and Class comments
Merged

Comments & Activities

Gitlab CI - PHPCS - Return comments and Class comments

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!443Gitlab CI - PHPCS - Return comments and Class commentsMerged

Comments & Activities

!443Gitlab CI - PHPCS - Return comments and Class comments
Merged