Contrib.social

Undefined array key "classes" in template_preprocess_views_bootstrap_media_object()

Open on Drupal.org →
Created on 8 March 2024, about 1 year ago
Updated 12 March 2024, about 1 year ago

Problem/Motivation

I ran in the situation that hundreds and thousands of php warning are created in the watchdog log:

Warning: Undefined array key "classes" in template_preprocess_views_bootstrap_media_object() (line 191 of /var/www/html/web/modules/contrib/views_bootstrap/views_bootstrap.theme.inc)

and

Warning: Undefined array key 0 in template_preprocess_views_bootstrap_media_object() (line 191 of /var/www/html/web/modules/contrib/views_bootstrap/views_bootstrap.theme.inc)

Seen this for PHP8.0 and PHP8.1 and both in Drupal 9 and 10.

Steps to reproduce

It might be a follow-up issue of something else, but seeing the code I think this was a left-over from when PHP7 was used by this module:

  $vars['classes'][$id] .= ' media-object';

Proposed resolution

Something like this:

  if (!isset($vars['classes'])) {
    $vars['classes'] = [];
  }
  foreach ($vars['rows'] as $id => $row) {
    $vars['rows'][$id] = [];
    if (!isset($vars['classes'][$id])) {
      $vars['classes'][$id] = '';
    }
    $vars['classes'][$id] .= ' media-object';
    $vars['rows'][$id]['image_class'] = $image_class;
    $vars['rows'][$id]['image'] = $vars['view']->style_plugin->getField($id, $image_field);
    $vars['rows'][$id]['heading'] = $vars['view']->style_plugin->getField($id, $heading_field);
    $vars['rows'][$id]['body'] = $vars['view']->style_plugin->getField($id, $body_field);
  }
🐛 Bug report
Status

Needs review

Version

4.4

Component

Media object

Created by

🇳🇱Netherlands Ronald van Belzen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024