- Issue created by @ptmkenny
- Status changed to Needs review
10 months ago 5:40am 8 March 2024 - 🇯🇵Japan ptmkenny
I opted to make the constructor final rather than the entire class, because it may be that someone builds on top of this module and wants to extend the validator class.
- Assigned to jonathanshaw
- 🇬🇧United Kingdom jonathanshaw Stroud, UK
I'm happy with that. A pit puzzled by where this static is, I can't see one :)
- Issue was unassigned.
- Status changed to Active
10 months ago 4:24pm 8 March 2024 - 🇯🇵Japan ptmkenny
Ok, great. I think the point of this rule is "lock down the class somehow so that people don't extend it haphazardly, making debugging harder." But to do that they have confusingly named rules... =)
-
ptmkenny →
committed bc0c8194 on 1.0.x
Issue #3426543 by ptmkenny, jonathanshaw: Fix the CI phpstan test
-
ptmkenny →
committed bc0c8194 on 1.0.x
- Status changed to Fixed
10 months ago 4:32pm 8 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.