- Issue created by @TeeBeeCoder
- Status changed to Needs review
9 months ago 3:36pm 7 March 2024 - First commit to issue fork.
- Issue was unassigned.
Here is MR 26 with minimal changes.
Would be better to add only integration with Gitalab here. Any changes related to code style should be a part of another task.
- 🇮🇳India nikunjkotecha India, Gujarat, Rajkot
I reviewed both and considering that merge of 26 will start giving errors for the lint I am thinking of merging https://git.drupalcode.org/project/search_api_algolia/-/merge_requests/2..., @David, any other reason apart from ticket scope?
@nikunjkotecha,
Personally, I'm not sure that the phpcs.xml.dist and phpstan.neon files are needed in MR20 at this moment and I don't like new changes in composer.json - "require-dev" and "configuration:allow plugins". Also not all errors have been fixed now - https://git.drupalcode.org/issue/search_api_algolia-3426387/-/jobs/1015711.
As I see, there are 2 ways here:
- fix phpstan errors in MR 20, decide whether the files are needed or not and accept all the changes
- add only integration with gitlab with MR 26 and fix errors in another task.
Both ways are fine for me. Anyway it's up to you.
- Status changed to Fixed
4 months ago 8:29am 21 July 2024 -
nikunjkotecha →
committed 74c53f51 on 3.0.x authored by
davps →
Issue #3426387 by TeeBeeCoder, davps, nikunjkotecha: Enable DA GitLab CI...
-
nikunjkotecha →
committed 74c53f51 on 3.0.x authored by
davps →
Automatically closed - issue fixed for 2 weeks with no activity.