Contrib.social

Add tests for SystemMenuNavigationBlock

Open on Drupal.org →
Created on 7 March 2024, 10 months ago
Updated 29 March 2024, 9 months ago

Problem/Motivation

Add tests for SystemMenuNavigationBlock based on the ones defined in SystemMenuBlockTest.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Merge request !184Issue #3426374: Tests for SystemMenuNavigationBlock → (Merged) created by plopesc
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇪🇸Spain plopesc Valladolid

    MR created

  • Pipeline finished with Success
    10 months ago
    Total: 170s
    #113802
  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇨🇦Canada m4olivei Grimsby, ON

    Thanks @plopesc! See comments, all small tweaks needed.

  • Pipeline finished with Success
    10 months ago
    Total: 144s
    #114458
  • Pipeline finished with Success
    10 months ago
    Total: 149s
    #114466
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇪🇸Spain plopesc Valladolid

    Thank you for your feedback @m4olivei!

    Comments addressed. I hope it's ready now.

  • Pipeline finished with Success
    10 months ago
    Total: 173s
    #114705
  • Pipeline finished with Skipped
    10 months ago
    #114938
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇨🇦Canada m4olivei Grimsby, ON

    Changes look great! Just noticing that phpcs is complaining about some of the new code here. Do you mind making those adjustments?

  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #118286
  • Pipeline finished with Success
    9 months ago
    Total: 145s
    #118288
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇪🇸Spain plopesc Valladolid

    Thank you for the heads up @m4olivei!

    Went ahead and fixed not only the phpcs issues related to this tests to leave the ground clean.

  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇨🇦Canada m4olivei Grimsby, ON

    Looks great!

    Sweet, sweet, green checkmark ✅.

  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇪🇸Spain ckrina Barcelona

    Merged, thanks!

  • Pipeline finished with Success
    9 months ago
    Total: 137s
    #119799
  • Comment 9 months ago →
    System Message
  • Comment 9 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    8 months ago
    Total: 57s
    #147866
  • Pipeline finished with Success
    8 months ago
    Total: 53s
    #147873
  • Pipeline finished with Success
    8 months ago
    #147879
  • Pipeline finished with Success
    8 months ago
    Total: 329s
    #148147
  • Pipeline finished with Success
    7 months ago
    Total: 150s
    #191661
  • Pipeline finished with Success
    7 months ago
    Total: 202s
    #191668
  • Pipeline finished with Canceled
    5 months ago
    Total: 2045s
    #226726
  • Pipeline finished with Success
    5 months ago
    Total: 1337s
    #226762
  • Pipeline finished with Success
    5 months ago
    Total: 1161s
    #226810
  • Pipeline finished with Success
    5 months ago
    Total: 13828s
    #226841
  • Pipeline finished with Success
    5 months ago
    #229798
  • Pipeline finished with Canceled
    5 months ago
    #239744
  • Pipeline finished with Failed
    5 months ago
    Total: 1063s
    #239749
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024