The "skip step"/"skip and finish" button UX is confusing because the error "TFA setup canceled" is then shown when clicked

Created on 7 March 2024, 4 months ago
Updated 1 May 2024, about 2 months ago

Hello all,

When a user is going through the TFA setup process and, for example, reaches the "Do you want to trust this browser?" form, they are shown the option to skip and finish.

Clicking this button shows a confusing error: "TFA setup canceled".

But 2FA is configured correctly.

I'm not really sure what the best solution here is; for our purposes I'm going to patch the module to remove the skip/cancel option entirely as it seems superfluous, particularly on the "remember browser" form where you can simply untick the "remember" checkbox and proceed.

In case it's useful, I'm attaching a patch :)

/A

🐛 Bug report
Status

Postponed: needs info

Version

1.0

Component

User interface

Created by

🇬🇧United Kingdom alexharries

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @alexharries
  • Status changed to Postponed: needs info 4 months ago
  • 🇬🇧United Kingdom alexharries

    Yes, it certainly looks like the same issue.

    Perhaps removal of the skip/cancel button is the simplest solution?

    I'm sure there's a use case where it could prove useful but from looking at the code, creating a universal fix which for example would resolve #2932071 might be more squeeze than the juice is worth... ¯\_(ツ)_/¯

    /A

  • 🇺🇸United States cmlara

    In 🐛 Give more accurate feedback when canceling a plugin setup Fixed we changed the text to say "Setup of @plugin_label canceled." instead of saying the entire setup has been canceled, it should (hopefully) imply that just a single plugin was stopped. It will be included in the next non-security release.

    Perhaps removal of the skip/cancel button is the simplest solution?

    I believe that may force users to setup multiple plugins even when they do not wish to do so.

    I do believe we need to do something with the multi step wizard, though I haven't personally looked in depth to determine how to clean it up.

    📌 Convert TFA plugin forms to use subforms Active and 📌 Convert plugin configuration to Config Entities Active might end up being related as they both involve restructuring of how we interact with the plugins for configuration.

  • 🇮🇳India Suryakumar1626

    Instead of Removing the skip/cancel button, we can add condition in showing the message, if the save button is avaialble in the form object. This condition will satisfy and show a message, if we clicked cancelled while setup any of the TFA plugins else it wont show the message when clicking the cancel button.

Production build 0.69.0 2024