- Issue created by @plopesc
- Status changed to Needs review
10 months ago 8:58am 7 March 2024 - 🇪🇸Spain plopesc Valladolid
MR created.
As part of the test creation process found that we forgot to include the "Broken" navigation block plugin for situations where the specified plugin is not available for any reason.
- Issue was unassigned.
- Status changed to Needs work
10 months ago 5:33pm 7 March 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Great to see the tests starting to be written. Nice that they are already working to find things we missed (eg. Broken plugin for Navigation Blocks).
Thanks @plopsec! Just a couple minor notes to address, otherwise looking good.
- Status changed to Needs review
10 months ago 9:09am 8 March 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for your feedback @m4olivei!
Comments addressed. I hope it's ready now.
- Status changed to Needs work
9 months ago 2:00pm 13 March 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Thanks for the changes! Just an unused use statement to clean up, then we're good!
- Status changed to Needs review
9 months ago 2:24pm 13 March 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for the heads up!
Test PHPCS issues should be fixed now.
- Status changed to RTBC
9 months ago 5:58pm 14 March 2024 - Status changed to Fixed
9 months ago 9:26am 15 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.