Add tests for NavigationBlockManager class

Created on 7 March 2024, 10 months ago
Updated 29 March 2024, 9 months ago

Problem/Motivation

Add test coverage for NavigationBlockManager inspired in BlockManagerTest class

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
  • testing

    Used for Documentation issues related to testing and test development

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Merge request !182Issue #3426283: Add NavigationBlockManager tests → (Merged) created by plopesc
  • Status changed to Needs review 10 months ago
  • 🇪🇸Spain plopesc Valladolid

    MR created.

    As part of the test creation process found that we forgot to include the "Broken" navigation block plugin for situations where the specified plugin is not available for any reason.

  • Pipeline finished with Success
    10 months ago
    #113579
  • Issue was unassigned.
  • 🇪🇸Spain plopesc Valladolid
  • Pipeline finished with Success
    10 months ago
    Total: 144s
    #113619
  • Pipeline finished with Success
    10 months ago
    Total: 167s
    #113804
  • Status changed to Needs work 10 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Great to see the tests starting to be written. Nice that they are already working to find things we missed (eg. Broken plugin for Navigation Blocks).

    Thanks @plopsec! Just a couple minor notes to address, otherwise looking good.

  • Pipeline finished with Success
    10 months ago
    Total: 146s
    #114366
  • Status changed to Needs review 10 months ago
  • 🇪🇸Spain plopesc Valladolid

    Thank you for your feedback @m4olivei!

    Comments addressed. I hope it's ready now.

  • Status changed to Needs work 9 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Thanks for the changes! Just an unused use statement to clean up, then we're good!

  • Pipeline finished with Success
    9 months ago
    Total: 146s
    #118287
  • Status changed to Needs review 9 months ago
  • 🇪🇸Spain plopesc Valladolid

    Thank you for the heads up!

    Test PHPCS issues should be fixed now.

  • Pipeline finished with Success
    9 months ago
    Total: 149s
    #118289
  • Status changed to RTBC 9 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Great! Thanks so much. RTBC.

  • Pipeline finished with Success
    9 months ago
    Total: 185s
    #119806
  • Status changed to Fixed 9 months ago
  • 🇪🇸Spain ckrina Barcelona

    Merged! Thanks for getting all this tests in :)

  • Pipeline finished with Success
    9 months ago
    #119818
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    8 months ago
    Total: 488s
    #144646
  • Pipeline finished with Skipped
    8 months ago
    #146964
  • Pipeline finished with Success
    7 months ago
    Total: 149s
    #190605
  • Pipeline finished with Success
    7 months ago
    Total: 150s
    #193047
  • Pipeline finished with Success
    5 months ago
    Total: 1341s
    #222558
  • Pipeline finished with Success
    5 months ago
    Total: 1095s
    #238560
  • Pipeline finished with Success
    4 months ago
    Total: 215s
    #250574
Production build 0.71.5 2024