- Issue created by @VladimirAus
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3426247-php-deprecated-explode to hidden.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3426247-php-deprecated-explode to active.
- Status changed to Needs review
10 months ago 5:23am 7 March 2024 - Merge request !233Issue #3426247: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string → (Open) created by VladimirAus
- last update
10 months ago 791 pass - 🇮🇱Israel jsacksick
We can maybe make it simpler and just do:
explode('-', $langcode ?? '') - Status changed to Needs work
10 months ago 12:29pm 7 March 2024 - last update
10 months ago 793 pass - Status changed to Needs review
10 months ago 3:12pm 7 March 2024 - Status changed to Needs work
10 months ago 3:16pm 7 March 2024 - Status changed to Needs review
10 months ago 7:05am 8 March 2024 - 🇮🇱Israel jsacksick
Actually... It doesn't seem that $language->getId() can return NULL.
See:
Variable $langcode on left side of ?? always exists and is not nullable.
Could be that $language is NULL? But not really since that would cause a crash.. PHPStan is complaining about the change so we can't merge this as is... - Status changed to Closed: won't fix
8 months ago 10:46am 10 May 2024 - 🇮🇱Israel jsacksick
Major Code Quality Finding Description Variable $langcode on left side of ?? always exists and is not nullable. File src/Resolver/DefaultLocaleResolver.php:48 Tool Code Quality - 🇦🇺Australia VladimirAus Brisbane, Australia
It crashed for me so it could at one point. 🤷♂️