Respect language, cache metadata and revision id

Created on 6 March 2024, 4 months ago

Updated 23 May 2024, about 1 month ago

Problem/Motivation

First of all, thank you for this nice module!

I notice 3 problems:

When used with entity_reference_revision, it always displays the active revision, even when looking at a draft or another revision of the host entity.
The language is not respected, see 🐛 Missing support for Entity Translations in FormatterBase.php Needs work .
Cache metadata from the access check is not applied to the render element.

Steps to reproduce

Case 1: Revision support
On a website with paragraphs or another kind of "sub-entity", and content revision workflow.
A node type with paragraphs field, where the paragraphs are displayed with reference_table_formatter.
Edit a node with a paragraph.
Change some value in the paragraph.
Save as draft.
View the draft.

Expected: Forward revision of the paragraph is shown.
Actual: Active revision is shown (same as for published version of the content).

Case 2: Translation
See 🐛 Missing support for Entity Translations in FormatterBase.php Needs work

Case 3: Cacheability
I have not come up with a scenario yet :)

Proposed resolution

Apply change from 🐛 Missing support for Entity Translations in FormatterBase.php Needs work for translation support.

Use $items->referencedEntities() to support revisions.

Collect cache metadata from the access checks.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany donquixote

Live updates comments and jobs are added and updated live.

Merge Requests

!4Respect language, cache metadata and revision id
Open
🇩🇪Germany donquixote
updated 4 months ago

Comments & Activities

Issue created by @donquixote
Merge request !4Issue #3426204: Respect revisions, access cache and translations → (Open) created by donquixote
Status changed to Needs review 4 months ago11:07pm 6 March 2024
Comment 4 months ago →
🇩🇪Germany donquixote
This still needs tests..
Comment about 1 month ago →
🇸🇦Saudi Arabia ahmedx
Thank you donquixote,
I'm using it for paragraphs module and i have tested the code from this merge and i can confirm that it works as expected.
i created it as patch for my own project. It would be great to see it merged into the module soon.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024