- Issue created by @gxleano
- Merge request !142Issue #3304728 by kristiaanvandeneynde: Add member page missing due to... β (Open) created by gxleano
- πͺπΈSpain gxleano CΓ‘ceres
gxleano β changed the visibility of the branch 3426098-add-cspell-integration-to-2.3.x to hidden.
- Status changed to Needs review
9 months ago 4:21pm 6 March 2024 - Status changed to Needs work
9 months ago 2:09pm 7 March 2024 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Thanks for starting on this! Rather than dumping all of the reported errors in a dictionary, I think we should ignore a few paths and then perhaps put the remaining stuff in a dictionary. After that we can evaluate if we need to split up the dictionaries (e.g. in group, group-tests, etc.)
Setting to NW because I think we need to re-declare the core dictionaries and then we should add some sane ignore files first.
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
See https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes... for how cspell is run, it doesn't seem to use both the default and ours as an override, but rather ours as the single source of truth.
- πͺπΈSpain gxleano CΓ‘ceres
Based on https://www.drupal.org/project/gitlab_templates/issues/3426392 β
I've removed
.cspell.json
and updatedictionary.txt
to.cspell-project-words.txt
So, once https://www.drupal.org/project/gitlab_templates/issues/3426392 β will be released, we will need to clean up
.cspell-project-words.txt
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Removed the console output from the IS. GitLab Templates has a new release that should ignore composer.json but I'm not seeing that in the results. Will adjust the MR a bit and see if it will work then (by picking up the latest tag).
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Commented out the core stuff as that should be detected again. We'll see
- Status changed to Needs review
8 months ago 2:07pm 12 March 2024 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Was able to drop Drupal vocabulary
-
kristiaanvandeneynde β
committed f5d28177 on 3.3.x authored by
gxleano β
Issue #3426098 by gxleano, kristiaanvandeneynde: Add CSPELL integration...
-
kristiaanvandeneynde β
committed f5d28177 on 3.3.x authored by
gxleano β
- Status changed to Fixed
8 months ago 3:11pm 12 March 2024 -
kristiaanvandeneynde β
committed 60cfe184 on 2.3.x authored by
gxleano β
Issue #3426098 by gxleano, kristiaanvandeneynde: Add CSPELL integration...
-
kristiaanvandeneynde β
committed 60cfe184 on 2.3.x authored by
gxleano β
Automatically closed - issue fixed for 2 weeks with no activity.