Remove outdated workarounds for null config override language

This is the crashing code:

  public function __construct(CacheBackendInterface $cache, LanguageManagerInterface $language_manager) {
    parent::__construct();

    $this->cache = $cache;
    // The getCurrentLanguage() fallback is a workaround for core bug #2684873.
    $language = $language_manager->getConfigOverrideLanguage() ?: $language_manager->getCurrentLanguage();
    $this->defaultLocale = $language->getId();
  }

It should not be possible for $language->getId() to be null. It indicates something very wrong with your site (or a core bug).

I suggest adding some debug code here to see which language is used (config override or current language) and what the value of $language is.

Thanks @bojanz.
MR is created.

VladimirAus → changed the visibility of the branch 3425922-error-cannot-assign to hidden.

VladimirAus → changed the visibility of the branch 3425922-error-cannot-assign to hidden.

VladimirAus → changed the visibility of the branch 3425922-error-cannot-assign to hidden.

VladimirAus → changed the visibility of the branch 3425922-error-cannot-assign to hidden.

VladimirAus → changed the visibility of the branch 3425922-error-cannot-assign to active.

@VladimirAus
Can you give us the output of this:

    var_dump($language_manager->getConfigOverrideLanguage());
   var_dump($language_manager->getConfigOverrideLanguage()->getId());

From what I can see, core issue #2684873: ConfigurableLanguageManager::getConfigOverrideLanguage() returns NULL → was fixed ages ago (Drupal 8.3), so our logic should be as simple as:

    $this->defaultLocale = $language_manager->getConfigOverrideLanguage()->getId();

According to the interfaces, getConfigOverrideLanguage() always returns a language, and getId() always returns a string, so a crash should be impossible.

Let me have a look @bojanz

@VladimirAus
Ever managed to look at this?

I'd still like to do the simplification from #14.

bojanz → changed the visibility of the branch 3425922-error-cannot-assign to hidden.

Just tested in on core 10.3.1 and address 2.0.2 and can not replicate the issue anymore. 🤷‍♂️

Found one in AddressItem as well.

Build is green, let's proceed.

Automatically closed - issue fixed for 2 weeks with no activity.