Avoid Drupal calls

There are no classes in the entire module. However, there are some phpcs issues found when running this command - ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,css,js,theme,info,txt,yml web/modules/custom/tagadelic/

Results -

FILE: /var/www/drupal/dummy/web/modules/custom/tagadelic/tagadelic.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 53 ERRORS AND 3 WARNINGS AFFECTING 46 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
   8 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 3
   9 | ERROR   | [x] Case breaking statement indented incorrectly; expected 5 spaces, found 6
  17 | ERROR   | [x] Concat operator must be surrounded by a single space
  70 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
  78 | ERROR   | [ ] The array declaration extends to column 220 (the limit is 120). The array content should be split up over multiple lines
 120 | ERROR   | [ ] Missing parameter type
 148 | ERROR   | [x] Whitespace found at end of line
 152 | ERROR   | [ ] join() is a function name alias, use implode() instead
 208 | ERROR   | [x] Concat operator must be surrounded by a single space
 218 | ERROR   | [ ] Missing parameter type
 235 | ERROR   | [x] Expected 1 blank line after function; 2 found
 241 | ERROR   | [ ] Missing parameter type
 264 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 266 | ERROR   | [ ] Missing parameter type
 268 | ERROR   | [ ] Missing parameter type
 271 | ERROR   | [x] Separate the @param and @return sections by a blank line.
 271 | ERROR   | [ ] Return type missing for @return tag in function comment
 280 | ERROR   | [x] Expected one space after the comma, 0 found
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 280 | ERROR   | [x] Concat operator must be surrounded by a single space
 282 | ERROR   | [x] Concat operator must be surrounded by a single space
 293 | ERROR   | [x] Concat operator must be surrounded by a single space
 293 | ERROR   | [x] Concat operator must be surrounded by a single space
 309 | ERROR   | [ ] Missing parameter type
 313 | ERROR   | [ ] Missing parameter type
 317 | ERROR   | [ ] Return type missing for @return tag in function comment
 347 | WARNING | [ ] '@todo' should match the format '@todo Fix problem X here.'
 349 | ERROR   | [ ] Wrong function doc comment end; expected "*/", found "**/"
 351 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 355 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 358 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 381 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 400 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 400 | ERROR   | [x] Array closing indentation error, expected 6 spaces but found 8
 402 | ERROR   | [x] Concat operator must be surrounded by a single space
 410 | ERROR   | [ ] Missing parameter type
 412 | ERROR   | [ ] Missing parameter type
 432 | ERROR   | [ ] Missing parameter type
 440 | ERROR   | [x] Concat operator must be surrounded by a single space
 440 | ERROR   | [x] Concat operator must be surrounded by a single space
 450 | ERROR   | [x] Concat operator must be surrounded by a single space
 451 | ERROR   | [x] Concat operator must be surrounded by a single space
 453 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 455 | ERROR   | [x] Concat operator must be surrounded by a single space
 456 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 462 | ERROR   | [x] Concat operator must be surrounded by a single space
 465 | ERROR   | [x] Concat operator must be surrounded by a single space
 466 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 495 | ERROR   | [x] Concat operator must be surrounded by a single space
 502 | ERROR   | [x] Concat operator must be surrounded by a single space
 515 | WARNING | [x] A comma should follow the last multiline array item. Found: )
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/drupal/dummy/web/modules/custom/tagadelic/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------
 3 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
 4 | WARNING | [ ] Line exceeds 80 characters; contains 178 characters
 5 | WARNING | [ ] Line exceeds 80 characters; contains 272 characters
 9 | ERROR   | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /var/www/drupal/dummy/web/modules/custom/tagadelic/tagadelic.css
------------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 13 LINES
------------------------------------------------------------------------------
  4 | ERROR | [x] There must be no space before a colon in a style definition
  9 | ERROR | [x] There must be no space before a colon in a style definition
 12 | ERROR | [x] There must be no space before a colon in a style definition
 15 | ERROR | [x] There must be no space before a colon in a style definition
 18 | ERROR | [x] There must be no space before a colon in a style definition
 21 | ERROR | [x] There must be no space before a colon in a style definition
 24 | ERROR | [x] There must be no space before a colon in a style definition
 27 | ERROR | [x] There must be no space before a colon in a style definition
 30 | ERROR | [x] There must be no space before a colon in a style definition
 33 | ERROR | [x] There must be no space before a colon in a style definition
 36 | ERROR | [x] There must be no space before a colon in a style definition
 37 | ERROR | [x] Expected 1 newline at end of file; 2 found
 38 | ERROR | [x] Additional whitespace found at end of file
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------


FILE: /var/www/drupal/dummy/web/modules/custom/tagadelic/tagadelic.install
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
 16 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 190ms; Memory: 14MB

Mohd Sahzad → made their first commit to this issue’s fork.

I guess you are not familiar with the module and use the incorrect version.

There are \Drupal calls in some classes e.g. TagadelicSettingsForm.php or TagadelicCloudTaxonomy.php in 4.0.x branch.
and the issue is only to fix DI.

The MR should only contain fixes for DI.

AstonVictor → closed merge request !11

Created and merged a new MR.

Fixed all DI. Note the task is not about fixing CS, there is another task for it.

Automatically closed - issue fixed for 2 weeks with no activity.