implement QueueFactoryInterface

Created on 5 March 2024, 12 months ago
Updated 22 June 2024, 8 months ago

Problem/Motivation

📌 Queue factory services do not conform to an interface RTBC adds a QueueFactoryInterface which will be required in Drupal 11.

At the moment the interface doesn't exist in 10.2.

It might be possible to conditionally define/class_alias the interface for 10.2 compatibility, or potentially for core to backport the interface to 10.2 (without any deprecations) so it's available. The latter would mean introducing a minimum core requirement on a 10.2 patch release ofc.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • First commit to issue fork.
  • Merge request !28enable next minor/major testing → (Merged) created by berdir
  • Pipeline finished with Failed
    12 months ago
    #113232
  • Status changed to Needs work 12 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Went down quite a rabbit hole of getting our GitlabCI configuration updated to run on next minor/major. And that's all green now, but I did _not_ yet do anything about the QueueFactoryInterface. Which I think shows that we are missing test coverage for that. There really aren't many things in core doing queue stuff, and we're not yet triggering that in the web test. The queue kernel tests apparently bypass the factory/discovery, so that still works.

  • Status changed to Active 11 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Committed these changes in 📌 Expand CI testing to next minor/major, fix tests on 10.2 Fixed so this can then focus on the Queue stuff.

    Interestingly, neither our queue kernel tests nor the web test is actually failing on this on D11. There is barely anything left in core that can be used for real-world queue testing.

  • Pipeline finished with Skipped
    9 months ago
    #194284
    • Berdir committed ab81caa3 on 8.x-1.x
      Issue #3425760: implement QueueFactoryInterface
      
  • Status changed to Fixed 9 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Nothing in core verifies this, so it's not possible to have failing tests. Merged.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024