- Issue created by @andrii momotov
- Assigned to andrii momotov
- Issue was unassigned.
- Status changed to Needs review
10 months ago 9:01pm 4 March 2024 - 🇺🇦Ukraine andrii momotov
Changed popin.info.yml for Drupal 10 Compatibility. Please check.
Thanks! - Status changed to RTBC
9 months ago 4:15pm 13 March 2024 - 🇺🇸United States RobbyMo
Verified Drupal 10 compatibility issues resolved from merge request 4 on 2.0.x branch testing on Drupal 10.1.8.
I think this is a great little popup module. After configuring the popin settings and placing the block the popup displayed and cookie was set as expected.
One thing to note since 'core: 8.x' is not included in the popin.info.yml file this will not work with Drupal core versions below 8.7.7 - see https://www.drupal.org/node/3070687 → . If you would like for this to be usable on all Drupal 8 versions I would suggest adding the 'core: 8.x' to the file as well, otherwise updating the core_version_requirement to be ^8.8 || 9 || 10 will ensure that the module installs on the correct versions that recognize the core_version_requirement key.
-
Andrii Momotov →
committed 5c7bea51 on 2.0.x
Resolve #3425549 "Drupal 10 compatibility"
-
Andrii Momotov →
committed 5c7bea51 on 2.0.x
- Status changed to Fixed
9 months ago 7:38pm 26 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.