In ExternalEntityType class, the public method setFieldMapperId() (currently only used in tests in this module) changes the field mapper plugin id while it does not reset the fieldMapperPlugin member which may have been initialized with a different field mapper id:
/**
* {@inheritdoc}
*/
public function setFieldMapperId($field_mapper_id) {
$this->field_mapper_id = $field_mapper_id;
}
/**
* {@inheritdoc}
*/
public function getFieldMapper() {
if (!$this->fieldMapperPlugin) {
$field_mapper_plugin_manager =
\Drupal::service('plugin.manager.external_entities.field_mapper');
assert($field_mapper_plugin_manager instanceof FieldMapperManager);
$config = $this->getFieldMapperConfig();
// Allow the mapper to call back into the entity type (e.g., to fetch
// additional data like field lists from the remote service).
$config['_external_entity_type'] = $this;
$this->fieldMapperPlugin =
$field_mapper_plugin_manager->createInstance(
$this->getFieldMapperId(),
$config
);
}
return $this->fieldMapperPlugin;
}
Therefore, a developer may think calling setFieldMapperId() changes the field mapper but it does not and there can be a discrepancy between what is returned by ->getFieldMapperId() and ->getFieldMapper()->getPluginId() which could lead to unexpected behaviors. As well, the field mapper config is not changed and may not correspond to the field mapper.
/**
* {@inheritdoc}
*/
public function setFieldMapperId($field_mapper_id) {
$this->field_mapper_id = $field_mapper_id;
$this->fieldMapperPlugin = NULL;
$this->field_mapper_config = [];
}
Review the logic and merge.
None.
None.
None.
Fixed
3.0
Code
Issue #3425428: setFieldMapperId should reset fieldMapperPlugin member
Automatically closed - issue fixed for 2 weeks with no activity.