- Issue created by @mparker17
- Status changed to Closed: duplicate
8 months ago 12:23pm 6 August 2024 - 🇨🇦Canada mparker17 UTC-4
This was done in 📌 Drupal 11 compatibility fixes for sitemap Fixed so I'm closing this as a duplicate of that one.
When we enabled Drupal.org's GitLab CI support → in commit 36847a0, it started running PHPStan on the code.
PHPStan has pointed out some places where we should be using dependency injection ("\Drupal calls should be avoided in classes, use dependency injection instead").
See phpstan-baseline.neon for the list of files that should be using dependency injection.
One way to fix them is demonstrated in part of the changes to src/SitemapBase.php in commit 0208f8a; although there are other ways to fix them as well.
Fix these dependency injection problems. Remove them from phpstan-baseline.neon.
None.
None.
None.
Closed: duplicate
2.0
Code
This was done in 📌 Drupal 11 compatibility fixes for sitemap Fixed so I'm closing this as a duplicate of that one.