Use Gitlab CI

This needs to add the core patch using composer patches.

ptmkenny → changed the visibility of the branch 3425131-use-gitlab-ci to hidden.

ptmkenny → changed the visibility of the branch 3425131-use-gitlab-ci to hidden.

ptmkenny → changed the visibility of the branch 3425131-use-gitlab-ci to hidden.

ptmkenny → changed the visibility of the branch 3425131-use-gitlab-ci to hidden.

I added the patch. I'm using the merge request result directly, which I know can be a little dangerous, but since this module is dependent on that patch, I would rather have the tests start failing if the MR is changed in an incompatible way so that we can be aware of it.

I'm using the merge request result directly, which I know can be a little dangerous, but since this module is dependent on that patch, I would rather have the tests start failing if the MR is changed in an incompatible way so that we can be aware of it.

I think that's right from the point of our tests. But I'm concerned that this patch bubbles up into actual projects that use this module, which could break projects. The MR is against D11, and the latest version of the MR might stop applying at any time on on a D9 or D10 project.

Unfortunately I can't see a way to specify that a patch is a dev dependency not a production one.

I can't see we have an alternative but to include a downloaded patch with the module.

Alas this all seems pretty horrible to me from a release management point of view - as we need a different patch for D9 and D10 we should in theory run a different branch for each, identical except for the different patch file. However, I don't mind just dropping D9 support altogether and hope that the same patch keeps working for D10 and D11 for now.

What do you reckon?

My understanding of the docs is that there are two ways of applying the patches for GitLab CI:

1. Add the patch directly to the module's composer.json.
2. Add the patch as a JSON file in .gitlab-ci subdirectory.

I assumed that #2 only affects GitLab CI because the patch instruction is in the .gitlab-ci subdirectory, which shouldn't be processed by anything other than GitLab CI.

So this will fix the tests as long as we run against D11/D10, but it should have no impact whatsoever on sites that use this module (they will continue to have to install an appropriate patch themselves). So the way I did it, unless I am misunderstanding, I have specified the patch as a CI dependency and nothing else.

Sorry, you're obviously right! I just somehow missed that was in gitlab CI and assumed it was in composer.json. Thanks for educating me:)

Automatically closed - issue fixed for 2 weeks with no activity.