VarnishPurgerFormBase should load config without overrides

Open on Drupal.org →

Created on 1 March 2024, over 1 year ago

Problem/Motivation

See 🐛 Prevent saving config entities when configuration overrides are applied Needs work , the config form should load the config without any override, to avoid saving overridden config to the database.

Steps to reproduce

If you have something like this in your settings:

$config['varnish_purger.settings.8f9418a21b']['hostname'] = 'localhost';

You don't want this overridden value to be saved to the database when submitting the form.

Proposed resolution

VarnishPurgerFormBase should use ConfigEntityStorageInterface::loadOverrideFree() to load the config.

🐛 Bug report

Status

Active

Version

2.2

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!14VarnishPurgerFormBase should load config without overrides
Open
🇫🇷France prudloff
updated 3 months ago

Comments & Activities

Issue created by @prudloff
Merge request !14Issue #3424969: VarnishPurgerFormBase should load config without overrides → (Open) created by prudloff
Status changed to Needs review over 1 year ago2:43pm 1 March 2024
Comment over 1 year ago →
🇫🇷France prudloff Lille
First commit to issue fork.
Pipeline finished with Success
3 months ago
Total: 152s
#435779
Status changed to RTBC about 1 month ago8:28am 5 May 2025
Comment about 1 month ago →
🇫🇷France arousseau
The issue remains to this day, using the 8.x-2.3 version of varnish_purge

The MR fixes it and the correct, non-overridden config is loaded in the plugin configuration form.

This looks safe to merge and deals with a real problem.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024