- Issue created by @steven jones
- π¬π§United Kingdom steven jones
I've started work in the MR on this.
Things remaining:
- Have an upgrade path that doesn't assume that the redirect entities are in the database.
- Get tests passing (I've not touched them, I assume that they will break with these changes.)
- Add some more tests for enabled/disabled redirects.
- If the status column was in Drupal 6 redirect, add the migration code for that.
- See if the submodules need any changes.
- Consider changing the signature of
\Drupal\redirect\RedirectRepository::findMatchingRedirect
to accept an ENUM so that one could query for only disable redirects.
- Status changed to Needs review
over 1 year ago 4:07pm 4 March 2024 - last update
over 1 year ago 63 pass - π¬π§United Kingdom steven jones
Uploading a patch to get the tests tested. I've not added any new tests for this functionality yet.
- First commit to issue fork.
- Merge request !139Resolve #3424962 "Allow redirects to be disabled" β (Merged) created by amateescu
- π·π΄Romania amateescu
I started working on this feature as well from a different angle (Workspaces support) but didn't consider searching through the issue queue first.
However, after finding this issue, turns out my approach was almost identical, so I incorporated my changes into the existing work here :)
- π·π΄Romania amateescu
Decided to drop the behavior change for disabling redirects instead of deleting them on path alias updates, I think that should be discussed in a separate issue. This is fully ready for review now :)
-
berdir β
committed 64d7fbf5 on 8.x-1.x authored by
amateescu β
Issue #3424962 by amateescu, steven jones, alexpott: Allow redirects to...
-
berdir β
committed 64d7fbf5 on 8.x-1.x authored by
amateescu β
- π¬π§United Kingdom alexpott πͺπΊπ
berdir β credited alexpott β .
- π¨πSwitzerland berdir Switzerland
Yeah, maintaining update tests is a pain, not really motivated to do that. Merged.