- Issue created by @danielspeicher
- Merge request !6Issue #3424561: Avoid language part in base URL → (Merged) created by danielspeicher
- Status changed to Needs review
about 1 year ago 2:07pm 29 February 2024 - 🇩🇪Germany danielspeicher Steisslingen
Please take a look. I am not sure, if that "helper" function is appropriate. Feel free to suggest or refactor.
- Status changed to Needs work
about 1 year ago 9:50am 1 March 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
This looks great with one comment where we can simplify the Api version. You're right, as it now stands, no helper function is needed.
- Status changed to Needs review
about 1 year ago 11:58am 1 March 2024 - Status changed to Needs work
about 1 year ago 12:11pm 1 March 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
There is still redundant adding and removing of slashes in the Api example. I've added the code suggestion in the MR which seems a bit simpler. It is possible to apply such suggestions in the web UI, btw.
- Status changed to Needs review
about 1 year ago 12:33pm 1 March 2024 - 🇩🇪Germany danielspeicher Steisslingen
Ah, I overlooked the
substr
for the content path.What do you mean with Web ui?
- 🇩🇪Germany jurgenhaas Gottmadingen
What do you mean with Web ui?
When you open the MR in the browser, you get to the web UI and there you can see the comments inline in code, and in this case also the code suggestion that I made. There is a widget where you can just apply that suggestion without having to edit your code in the editor.
- 🇩🇪Germany danielspeicher Steisslingen
Oh, that is really useful. Did not remember, but we talked about it a few months ago.
-
danielspeicher →
committed 677c8ed4 on 2.5.x
Issue #3424561 by danielspeicher, jurgenhaas: Avoid language part in...
-
danielspeicher →
committed 677c8ed4 on 2.5.x
- Status changed to Fixed
about 1 year ago 2:06pm 1 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.