Attempt to determine if entity before running $this->getEntity($values)

Created on 28 February 2024, about 1 year ago

Updated 10 July 2024, 8 months ago

Problem/Motivation

I've noticed an error like Warning: Undefined array key "entity_type" in Drupal\views\Plugin\views\field\FieldPluginBase->getEntity() (line 444 of /core/modules/views/src/Plugin/views/field/FieldPluginBase.php) when using this field with non-entity-based views.

Steps to reproduce

1. Use the Denormalizer module to create a flat table.
2. Use the Views Database Connector module to access that table for your view.
3. Add a Views Simple Math Field field and perform a calculation.
4. Error like above shows in logs.

Proposed resolution

Check the $values array for an entity before running $this->getEntity($values).

Remaining tasks

Implement a fix, test.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States andileco

Live updates comments and jobs are added and updated live.

Merge Requests

!5Attempt to determine if entity before running $this->getEntity($values)
Merged
🇺🇸United States andileco
updated 9 months ago

Comments & Activities

Issue created by @andileco
Merge request !5Seeing if test will run remotely. → (Merged) created by andileco
Pipeline finished with Skipped
9 months ago
#208318
Comment 9 months ago →
System Message

andileco → committed b9df8301 on 3.0.x
Issue #3424225 by andileco: Attempt to determine if entity before...
Status changed to Fixed 9 months ago5:14am 26 June 2024
Comment 9 months ago →
🇺🇸United States andileco
Tested this manually...it made a huge performance improvement.
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024